summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichał Górny <mgorny@gentoo.org>2018-01-28 09:55:35 +0100
committerMichał Górny <mgorny@gentoo.org>2018-02-07 14:22:07 +0100
commita9971615ef69dbb26f04af2c9fd1cddd1ec6d626 (patch)
tree78a7e5723aba6e3fedda3b24a6e15d229f9a6672 /glep-0075.rst
parentglep-0075: Split distfile mirror directory structure (diff)
downloadglep-a9971615ef69dbb26f04af2c9fd1cddd1ec6d626.tar.gz
glep-a9971615ef69dbb26f04af2c9fd1cddd1ec6d626.tar.bz2
glep-a9971615ef69dbb26f04af2c9fd1cddd1ec6d626.zip
glep-0075: Include argument on injected distfiles
Include the argument that we have injected distfiles as noted on the bug by Robin. Inclusion suggested by Michael Orlitzky.
Diffstat (limited to 'glep-0075.rst')
-rw-r--r--glep-0075.rst5
1 files changed, 4 insertions, 1 deletions
diff --git a/glep-0075.rst b/glep-0075.rst
index c0a1d5c..ced1231 100644
--- a/glep-0075.rst
+++ b/glep-0075.rst
@@ -205,7 +205,7 @@ to split them further.
The alternate option of using file hash has the advantage of having
a more balanced split. Furthermore, since hashes are stored
-in Manifests using them is zero-cost. However, this solution has two
+in Manifests using them is zero-cost. However, this solution has three
significant disadvantages:
1. The hash values are unknown for newly-downloaded distfiles, so
@@ -216,6 +216,9 @@ significant disadvantages:
hash mismatches would be placed in the wrong subdirectory,
potentially causing confusing errors.
+3. Not all files in the distfiles tree are covered by package Manifests
+ --- there are additional files that are injected into distfiles.
+
Using filename hashes has proven to provide a similar balance
to using file hashes. Furthermore, since filenames are known up front
this solution does not suffer from the both listed problems. While