aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* [ticket/10760] Account for display_errors=stderr in pre-commit hook.Oleg Pudeyev2012-04-031-1/+7
| | | | | | | | | With that php.ini value set errors are printed to stderr, therefore by redirecting stderr to /dev/null we also throw out the errors. Instead merge stderr into stdout. PHPBB3-10760
* [ticket/10760] Quote PHP_BIN when using it.Oleg Pudeyev2012-04-031-2/+2
| | | | | | This should make a difference on windows where paths may include spaces. PHPBB3-10760
* [ticket/10760] Use echo -e only if echo understands -e.Oleg Pudeyev2012-04-031-2/+9
| | | | | | | | | /bin/echo on freebsd and dash's builtin echo do not understand -e, therefore -e is printed with the other messages in such cases. Test if echo understands -e, if not do not use it. PHPBB3-10760
* [ticket/10760] Use externally specified PHP_BIN if any.Oleg Pudeyev2012-04-031-3/+5
| | | | | | | | | | | | | We have a PHP_BIN variable but we always set it unconditionally, therefore in order to use a different php binary one had to modify the hook script. Instead set PHP_BIN if it is not set. Now one can set PHP_BIN in their environment to use a non-default php binary. PHPBB3-10760
* [ticket/10093] Use correct ANSI code for clearing color.Oleg Pudeyev2011-12-031-2/+2
| | | | PHPBB3-10093
* [ticket/10093] Make commit-msg always not fatal by nuking all fatal logic.Oleg Pudeyev2011-12-031-18/+3
| | | | PHPBB3-10093
* [ticket/10093] Use color in commit-msg hook warning/error messages.Oleg Pudeyev2011-11-261-1/+50
| | | | | | | By default color is used if the message is printed to a tty, phpbb.hooks.commit-msg.color configuration setting can override this. PHPBB3-10093
* [ticket/10093] Refactor complaining in commit-msg hook for color support.Oleg Pudeyev2011-11-261-17/+22
| | | | PHPBB3-10093
* [ticket/10093] Respect phpbb.hooks.commit-msg.fatal on syntax errors.Oleg Pudeyev2011-11-261-1/+1
| | | | PHPBB3-10093
* [ticket/10093] Document phpbb.hooks.commit-msg.fatal setting.Oleg Pudeyev2011-11-261-0/+5
| | | | PHPBB3-10093
* Merge branch 'ticket/p/10092' into develop-olympusAndreas Fischer2011-03-141-1/+1
|\ | | | | | | | | * ticket/p/10092: [ticket/10092] Ignore overlength comment lines in commit-msg hook.
| * [ticket/10092] Ignore overlength comment lines in commit-msg hook.Oleg Pudeyev2011-03-111-1/+1
| | | | | | | | PHPBB3-10092
* | [ticket/10078] Avoid \n in strings given to echo for portability.Oleg Pudeyev2011-03-111-2/+3
|/ | | | | | | Also preserve whitespace (including newlines) when printing the lines that exceed 80 character limit. PHPBB3-10078
* [ticket/9824] Accept commit messages with less than perfect headings.Oleg Pudeyev2011-03-011-1/+13
| | | | | | | | Some commit messages exist only temporarily, because they are given on commits that are intended to be squashed. Accept such commit messages with a warning. PHPBB3-9824
* [ticket/9824] Allow empty lines after ticket reference.Oleg Pudeyev2011-03-011-1/+8
| | | | PHPBB3-9824
* [ticket/9824] Use printf instead of echo to render \n.Oleg Pudeyev2011-03-011-1/+1
| | | | | | On FreeBSD `echo "\n"` prints \n verbatim. Use printf instead. PHPBB3-9824
* [ticket/9824] Handle empty commit messages in commit-msg hook.Oleg Pudeyev2011-03-011-0/+11
| | | | | | | | | Git already handles the case of commit message being empty by aborting the commit and displaying a reasonably helpful message. If there is no commit message, the hook will exit with success exit code to let git do its thing. PHPBB3-9824
* [ticket/9824] Add space after [ticket/12345] in prepared commit message.Andreas Fischer2011-03-021-1/+1
| | | | PHPBB3-9824
* [ticket/9824] Remove space after PHPBB3-12345 in prepared commit message.Andreas Fischer2011-03-021-1/+1
| | | | PHPBB3-9824
* Merge branch 'task/cs278/git-tools' into develop-olympusIgor Wiedler2010-09-091-4/+5
|\ | | | | | | | | | | * task/cs278/git-tools: [task/git-tools] Change the GNU --lines argument to the POSIX -l [task/git-tools] Solve dependency on the GNU wc --max-line-length option
| * [task/git-tools] Change the GNU --lines argument to the POSIX -lChris Smith2010-09-081-1/+1
| | | | | | | | | | | | | | | | Changed to awk which handles the formatting differences between the two versions of wc -- BSD version prefixes the output with spaces, the GNU version does not. PHPBB3-9808
| * [task/git-tools] Solve dependency on the GNU wc --max-line-length optionChris Smith2010-09-071-3/+4
| | | | | | | | PHPBB3-9808
* | [ticket/9777] Print error message in pre-commit hook when php is not installed.Oleg Pudeyev2010-08-191-0/+7
|/ | | | PHPBB3-9777
* [task/git-tools] Ignore git commit message commentsChris Smith2010-08-101-1/+13
| | | | | | | Git commit message comments can be contained anywhere in the message and this change ignores where they appear. PHPBB3-9768
* [task/git-tools] Adjust the hook to enforce that a ticket is always mentionedChris Smith2010-08-101-2/+2
| | | | PHPBB3-9768
* [task/git-tools] Vastly expanded commit-msg hook.Chris Smith2010-08-101-5/+224
| | | | | | | | | | | | | | | | This updated hook supports validates each line of the commit message confirms to the phpBB standards [1], there are two git config options which adjust the behaviour of the hook. They are: * phpbb.hooks.commit-msg.fatal: Set to false for the hook to allow commits with malformed structure, useful if you'll be squashing or editing the commits later. True is the default value. * phpbb.hooks.commit-msg.debug: Any integer value greater than 0 will increase the debugging verbosity of the hook, the default value is 0. [1] http://wiki.phpbb.com/display/DEV/Git PHPBB3-9768
* [task/git-tools] Beginnings of a syntax checking hook.Chris Smith2010-08-101-0/+26
| | | | | | Currently this hook checks line length is less than or equal to 80 characters. PHPBB3-9768
* [task/git-tools] Append ticket identifier to commit message prior to editing.Chris Smith2010-08-102-25/+9
| | | | PHPBB3-9770
* [task/git-tools] add install and uninstall scripts for hooksIgor Wiedler2010-07-122-0/+33
| | | | PHPBB3-9769
* [task/git-tools] move ticket id appending to commit-msg hookIgor Wiedler2010-07-122-7/+24
| | | | PHPBB3-9770
* [task/git-tools] append ticket id to git log messageIgor Wiedler2010-07-121-0/+7
| | | | PHPBB3-9770
* [git-tools] Use @ instead of : in sed command in pre-commit hook for wider ↵Oleg Pudeyev2010-04-131-1/+1
| | | | compatibility.
* [git-tools] Adjusted pre-commit hook to run under freebsd /bin/sh.Oleg Pudeyev2010-04-131-2/+5
|
* [git-tools] Changed pre-commit hook to use sh instead of bashOleg Pudeyev2010-04-131-1/+1
|
* [git-tools] add note about PHP_BIN using envIgor Wiedler2010-04-031-0/+1
|
* [git-tools] do not display stderrIgor Wiedler2010-04-031-1/+1
|
* [git-tools] Prepend the branch to the commit message for all branches.Chris Smith2010-04-031-1/+1
|
* [git-tools] Use env to find the correct paths to binaries.Chris Smith2010-04-031-2/+2
|
* [git-tools] Display what parse errors were found.Chris Smith2010-04-031-1/+6
|
* [git-tools] This script requires bash to run, so point directly to bash.Chris Smith2010-04-031-1/+1
|
* [git-tools] Improvements for the pre-commit hookIgor Wiedler2010-03-171-5/+28
| | | | | | | One major issue with the pre-hook so far was partially staged files, because it used filenames for php lint. These changes will make the hook read the file contents from the index instead. Great thanks to David Soria Parra.
* [git-tools] Improvements on prepare-commt-msg hookIgor Wiedler2010-03-131-6/+16
| | | | | | | prepare-commit-hook now uses `git symbolic-ref HEAD` instead of reading $GIT_DIR/HEAD directly. This seems to be a more portable solution. Thanks to Chris (cs278/ToonArmy) for the suggestion.
* [git-tools] Some pre-commit enhancements, abolish tempfileIgor Wiedler2010-03-111-4/+4
|
* [git-tools] use mktemp in pre-commit (thanks nn-)Igor Wiedler2010-03-101-2/+1
|
* [git-tools] pre-commit hook for syntax checkingIgor Wiedler2010-03-101-0/+44
| | | | | | | | This pre-commit hook utilises PHP's command-line -l (lint) option, which checks for syntax errors. In case of an error the commit is rejected and the error displayed. Testing is welcome.
* Add feature/ support to branchname hookIgor Wiedler2010-03-081-2/+2
| | | | | The previously introduced branchname hook now will also use feature/ branch names, in addition to the existing bug/.
* Adding a branchname prepare-commit-msg hookIgor Wiedler2010-03-081-0/+24
Git supports several hooks, some of which are client-side. The prepare-commit-msg hook is run right after a `git commit` call, before the editor is opened. This allows the initial message to be altered. This hook will check if the current branch name begins with `bug/`, in which case it will prepend `[$branchname]` to the commit message. This makes it easier to create proper commit messages. http://wiki.phpbb.com/Git#Commit_Messages For more information refer to the hook source.