From f72795c60b475cc36501ed03b7b3a03c38bcf851 Mon Sep 17 00:00:00 2001 From: Sam James Date: Sun, 21 Mar 2021 02:50:27 +0000 Subject: ebuild-writing/common-mistakes: mention "the compiler", not only GCC MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Sam James Signed-off-by: Ulrich Müller --- ebuild-writing/common-mistakes/text.xml | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/ebuild-writing/common-mistakes/text.xml b/ebuild-writing/common-mistakes/text.xml index 6f33248..9455688 100644 --- a/ebuild-writing/common-mistakes/text.xml +++ b/ebuild-writing/common-mistakes/text.xml @@ -176,13 +176,14 @@ Always check that it's really gone in the build log.

Specific -Werror=... flags

-GCC can turn any specific warning into an error. A specific -Werror flag would -be "-Werror=implicit-function-declaration" for example and will only affect -warnings about implicit function declarations. It's mostly safe to leave these -untouched, cause they are pinned to this issue and should not cause random -build time breakage. Also, we can expect that upstream did this on purpose to -avoid known runtime errors and not just for testing their builds. However you -should check the specified warnings yourself or ask other developers if unsure. +The compiler (e.g. GCC) can turn any specific warning into an error. A +specific -Werror flag would be "-Werror=implicit-function-declaration" for +example and will only affect warnings about implicit function declarations. It's +mostly safe to leave these untouched, cause they are pinned to this issue and +should not cause random build time breakage. Also, we can expect that upstream +did this on purpose to avoid known runtime errors and not just for testing their +builds. However, you should check the specified warnings yourself or ask other +developers if unsure.

Exceptions

-- cgit v1.2.3-65-gdbad