aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Ruppert <idl0r@gentoo.org>2013-05-11 21:11:12 +0200
committerChristian Ruppert <idl0r@gentoo.org>2013-05-11 21:11:12 +0200
commitea8d02eb24a636b0974bff595c9574a426b86ae5 (patch)
treee5ad0bf6099caf3ac55bbe122fb2558e6c24c6fb
parentRemove pipe chars (diff)
downloadgentoolkit-ea8d02eb24a636b0974bff595c9574a426b86ae5.tar.gz
gentoolkit-ea8d02eb24a636b0974bff595c9574a426b86ae5.tar.bz2
gentoolkit-ea8d02eb24a636b0974bff595c9574a426b86ae5.zip
Refactor pipe handle close
-rwxr-xr-xsrc/echangelog/echangelog4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/echangelog/echangelog b/src/echangelog/echangelog
index d6cb205..ab3c475 100755
--- a/src/echangelog/echangelog
+++ b/src/echangelog/echangelog
@@ -520,8 +520,8 @@ sub sortfunc($$) {
@ebuilds = grep(/\.ebuild$/, @files);
@files = grep(!/\.ebuild$/, @files);
-my $ph_diff;
if (@ebuilds) {
+ my $ph_diff;
if ($vcs eq "git") {
open($ph_diff, "-|", $vcs{$vcs}{diff}." HEAD -- @ebuilds 2>&1") or die "Can't run: ".$vcs{$vcs}{diff}."$!\n";
} else {
@@ -593,8 +593,8 @@ if (@ebuilds) {
mypush(@new_versions, $2);
}
}
+ close($ph_diff);
}
-close($ph_diff) if $ph_diff;
# Subversion diff doesn't identify new versions. So use the status command
if (($vcs eq "svn" or $vcs eq "hg") and (@ebuilds)) {