aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlex Vandiver <alexmv@dropbox.com>2017-05-09 17:54:21 -0700
committerSitaram Chamarty <sitaram@atc.tcs.com>2017-05-10 09:27:26 +0530
commit5f98ad37822c17878120b45b254b8ace2ec308d9 (patch)
tree89ccb75155af2cb11913359156cfeacd61d1e1c2
parentnew 'skip_block' sugar, and 'testconf' feature using it (diff)
downloadgitolite-gentoo-5f98ad37822c17878120b45b254b8ace2ec308d9.tar.gz
gitolite-gentoo-5f98ad37822c17878120b45b254b8ace2ec308d9.tar.bz2
gitolite-gentoo-5f98ad37822c17878120b45b254b8ace2ec308d9.zip
Fix SHA256 fingerprinting to match the full character set
Because of a one-bit typo, this only matched the fingerprint up until the first upper-case letter; this led to false-positive messages about hash collisions.
-rw-r--r--src/lib/Gitolite/Common.pm2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/lib/Gitolite/Common.pm b/src/lib/Gitolite/Common.pm
index 0465db1..7a52f4b 100644
--- a/src/lib/Gitolite/Common.pm
+++ b/src/lib/Gitolite/Common.pm
@@ -355,7 +355,7 @@ sub ssh_fingerprint_file {
# Return a valid fingerprint or undef
my $fp = undef;
if($output =~ /((?:MD5:)?(?:[0-9a-f]{2}:){15}[0-9a-f]{2})/i or
- $output =~ m{((?:RIPEMD|SHA)\d+:[A-ZA-z0-9+/=]+)}i) {
+ $output =~ m{((?:RIPEMD|SHA)\d+:[A-Za-z0-9+/=]+)}i) {
$fp = $1;
}
return wantarray ? ($fp, $output) : $fp;