diff options
| author |   Chris Lalancette <clalance@redhat.com> | 2010-07-30 09:39:48 -0400 |
|---|---|---|
| committer | Chris Lalancette <clalance@redhat.com> | 2010-07-30 10:01:50 -0400 |
| commit | 4313e1b9b12adcfda6972eab5ac69fb5d3e64bf0 (patch) | |
| tree | c774b1fd07b3ad9ca86539e81c0aade74ec0cd24 | |
| parent | esx: Fix freeing of heterogeneous lists (diff) | |
| download | libvirt-4313e1b9b12adcfda6972eab5ac69fb5d3e64bf0.tar.gz libvirt-4313e1b9b12adcfda6972eab5ac69fb5d3e64bf0.tar.bz2 libvirt-4313e1b9b12adcfda6972eab5ac69fb5d3e64bf0.zip | |
Fix a memory leak in the qemudBuildCommandLine.
ADD_ARG_LIT should only be used for literal arguments,
since it duplicates the memory. Since virBufferContentAndReset
is already allocating memory, we should only use ADD_ARG.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
| -rw-r--r-- | src/qemu/qemu_conf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 7c63bdcb3..a79e0d7d8 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -4110,7 +4110,7 @@ int qemudBuildCommandLine(virConnectPtr conn, goto error; } - ADD_ARG_LIT(virBufferContentAndReset(&boot_buf)); + ADD_ARG(virBufferContentAndReset(&boot_buf)); } if (def->os.kernel) { |