aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike Gilbert <floppym@gentoo.org>2020-03-05 15:26:29 -0500
committerMike Gilbert <floppym@gentoo.org>2020-03-05 16:28:26 -0500
commit2d9836a0c8bb313fa66581e6cf27fb1a86ada170 (patch)
treeeab5b4f44027746dc59d89844b7ed77b3015c1b0
parentAsynchronousTask: schedule start listeners via call_soon (bug 711322) (diff)
downloadportage-2d9836a0c8bb313fa66581e6cf27fb1a86ada170.tar.gz
portage-2d9836a0c8bb313fa66581e6cf27fb1a86ada170.tar.bz2
portage-2d9836a0c8bb313fa66581e6cf27fb1a86ada170.zip
repoman: remove check for addpredict
This function has not been deprecated, and developers generally have a good reason for using it. A repoman warning for this is just noise. No reason was given when this check was added in 2010, and it was requested by a developer who has since retired. Signed-off-by: Mike Gilbert <floppym@gentoo.org> Reviewed-by: Zac Medico <zmedico@gentoo.org>
-rw-r--r--repoman/cnf/linechecks/linechecks.yaml1
-rw-r--r--repoman/cnf/repository/repository.yaml1
-rw-r--r--repoman/lib/repoman/modules/linechecks/workaround/__init__.py6
-rw-r--r--repoman/lib/repoman/modules/linechecks/workaround/workarounds.py7
4 files changed, 0 insertions, 15 deletions
diff --git a/repoman/cnf/linechecks/linechecks.yaml b/repoman/cnf/linechecks/linechecks.yaml
index 410bcd9c5..2182b467a 100644
--- a/repoman/cnf/linechecks/linechecks.yaml
+++ b/repoman/cnf/linechecks/linechecks.yaml
@@ -28,7 +28,6 @@ errors:
PRESERVE_OLD_LIB: 'Ebuild calls deprecated preserve_old_lib'
BUILT_WITH_USE: 'built_with_use'
NO_OFFSET_WITH_HELPERS: 'Helper function is used with D, ROOT, ED, EROOT or EPREFIX'
- SANDBOX_ADDPREDICT: 'Ebuild calls addpredict'
USEQ_ERROR: 'Ebuild calls deprecated useq function'
HASQ_ERROR: 'Ebuild calls deprecated hasq function'
URI_HTTPS: 'Ebuild uses http:// but should use https://'
diff --git a/repoman/cnf/repository/repository.yaml b/repoman/cnf/repository/repository.yaml
index 935260424..ad00d18c1 100644
--- a/repoman/cnf/repository/repository.yaml
+++ b/repoman/cnf/repository/repository.yaml
@@ -71,6 +71,5 @@ linechecks_modules:
uselessdodoc
whitespace
blankline
- addpredict
noasneeded
diff --git a/repoman/lib/repoman/modules/linechecks/workaround/__init__.py b/repoman/lib/repoman/modules/linechecks/workaround/__init__.py
index 425085a5c..694695015 100644
--- a/repoman/lib/repoman/modules/linechecks/workaround/__init__.py
+++ b/repoman/lib/repoman/modules/linechecks/workaround/__init__.py
@@ -10,12 +10,6 @@ module_spec = {
'name': 'do',
'description': doc,
'provides':{
- 'addpredict-check': {
- 'name': "addpredict",
- 'sourcefile': "workarounds",
- 'class': "SandboxAddpredict",
- 'description': doc,
- },
'noasneeded-check': {
'name': "noasneeded",
'sourcefile': "workarounds",
diff --git a/repoman/lib/repoman/modules/linechecks/workaround/workarounds.py b/repoman/lib/repoman/modules/linechecks/workaround/workarounds.py
index 37cb54314..768a47e8e 100644
--- a/repoman/lib/repoman/modules/linechecks/workaround/workarounds.py
+++ b/repoman/lib/repoman/modules/linechecks/workaround/workarounds.py
@@ -9,10 +9,3 @@ class NoAsNeeded(LineCheck):
repoman_check_name = 'upstream.workaround'
re = re.compile(r'.*\$\(no-as-needed\)')
error = 'NO_AS_NEEDED'
-
-
-class SandboxAddpredict(LineCheck):
- """Check for calls to the addpredict function."""
- repoman_check_name = 'upstream.workaround'
- re = re.compile(r'(^|\s)addpredict\b')
- error = 'SANDBOX_ADDPREDICT'