| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch is a forward port of the following commit:
https://gitweb.gentoo.org/proj/gentoolkit.git/commit/?id=232d69fa230abb490e0b0f8eef550f28745be6a3
commit 232d69fa230abb490e0b0f8eef550f28745be6a3
Author: fuzzyray <fuzzyray@gentoo.org>
AuthorDate: 2009-06-22 20:45:49 +0000
Commit: fuzzyray <fuzzyray@gentoo.org>
CommitDate: 2009-06-22 20:45:49 +0000
Fix traceback with glsa-check -f (Bug 275105)
svn path=/trunk/gentoolkit/; revision=665
Bug: https://bugs.gentoo.org/693088
Acked-by: Aaron Bauman <bman@gentoo.org>
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch is a forward port of the following commit:
https://gitweb.gentoo.org/proj/gentoolkit.git/commit/?id=d3e4aad5a03efbd5089f96558d2ddd1e9bf158a8
commit d3e4aad5a03efbd5089f96558d2ddd1e9bf158a8
Author: vapier <vapier@gentoo.org>
AuthorDate: 2010-03-07 01:37:57 +0000
Commit: vapier <vapier@gentoo.org>
CommitDate: 2010-03-07 01:37:57 +0000
glsa-check: hide non-vuln glsas in quiet mode
svn path=/trunk/gentoolkit/; revision=750
Bug: https://bugs.gentoo.org/692872
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch is a forward port of the following commit:
https://gitweb.gentoo.org/proj/gentoolkit.git/commit/?id=cd5a8e80f949f649b6d2b174bc899f1f092684fd
commit cd5a8e80f949f649b6d2b174bc899f1f092684fd
Author: fuzzyray <fuzzyray@gentoo.org>
AuthorDate: 2009-05-07 22:15:50 +0000
Commit: fuzzyray <fuzzyray@gentoo.org>
CommitDate: 2009-05-07 22:15:50 +0000
Add patch from Robert Buchholz: Add quiet option
Incorporate option to quiet down glsa-check, based on a patch by Thilo
Bangert <bangert@gentoo.org> in bug #170784.
This option will also suppress sending of empty mail, based on a patch
by Christian Gut <cycloon@is-root.org> in bug #182990.
svn path=/trunk/gentoolkit/; revision=633
Bug: https://bugs.gentoo.org/692872
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
| |
* This simply aligns the help menu text with the man page
* Update copyright
* Bump version to 1.0.1
Signed-off-by: Aaron Bauman <bman@gentoo.org>
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
| |
This was inavertently reverted with commit 17ecafa949.
Fixes: 17ecafa949c87a6f2a2d2c98c7de18ed06f08f2f
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
| |
This was inavertently reverted with commit 17ecafa949.
Fixes: 17ecafa949c87a6f2a2d2c98c7de18ed06f08f2f
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
|
|
|
|
|
|
|
| |
This reverts commit 7cb39877b7f6231ce11f1161cf2d3fe42e287b59.
Bug: https://bugs.gentoo.org/692262
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
| |
As specified by PMS: "econf [...] Should any portion of it fail, it
must abort the build using die, unless run using nonfatal, in which
case it must return non-zero exit status."
https://projects.gentoo.org/pms/7/pms.html#x1-12800012.3.8
Bug: https://bugs.gentoo.org/692024
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As specified by PMS: "If unpacking a supported file format fails,
unpack shall abort the build process."
https://projects.gentoo.org/pms/7/pms.html#x1-13500012.3.15:
This partially reverts commit 525e69351d45621c34a9326fcbc11ca592cb6539,
as far as unpack() is concerned.
Bug: https://bugs.gentoo.org/691776
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the following AttributeError error:
# ebuild /var/db/pkg/sys-apps/portage-2.3.71/portage-2.3.71.ebuild clean pretend clean
Traceback (most recent call last):
File "/usr/lib/python-exec/python3.6/ebuild", line 318, in <module>
type_name=pkg_type)
File "/usr/lib64/python3.6/site-packages/_emerge/Package.py", line 72, in __init__
db = self.cpv._db
AttributeError: 'str' object has no attribute '_db'
Bug: https://bugs.gentoo.org/532674
Fixes: bfe7892202b8 ("_pkg_str: add _db attribute (bug 640318)")
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
| |
Respect PORTAGE_NICENESS variable.
Closes: https://github.com/gentoo/portage/pull/441
Signed-off-by: Felix Neumärker <xdch47@posteo.de>
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
| |
Bug: https://bugs.gentoo.org/690304
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable sync-webrsync-verify-signature by default in repos.conf (due to
dependencies the ebuild will make this conditional on USE=rsync-verify
in the same way as the default sync-rsync-verify-metamanifest value).
Use a new PORTAGE_TEMP_GPG_DIR variable to distinguish indirect
emerge-webrsync calls that use gemato for secure key refresh, and
disable direct emerge-webrsync calls.
Deprecate FEATURES=webrsync-gpg and use it to trigger a
backward-compatibility mode where direct emerge-webrsync calls are
allowed (but trigger a warning message). Since direct emerge-webrsync
calls do not use gemato for secure key refresh, this behavior will
not be supported in a future release.
Bug: https://bugs.gentoo.org/689506
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
| |
Suppress export error messages like this for eix-update:
/usr/lib/portage/python3.6/ebuild.sh: line 11: export: ___in_portage_iuse: not a function
Fixes: 7f1aac111320 ("ebuild.sh: unexport ___in_portage_iuse function (bug 680810)")
Bug: https://bugs.gentoo.org/680810
Bug: https://bugs.gentoo.org/689128
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
|
| |
The exported BASH_FUNC____in_portage_iuse%% variable can trigger
problems for some shells, so do not export it.
Reported-by: Fabian Groffen <grobian@gentoo.org>
Bug: https://bugs.gentoo.org/680810
Fixes: 9cac3bfa782f ("Speed up testing against IUSE by not using regexp")
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
| |
Bug: https://bugs.gentoo.org/686282
Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
| |
Do not report libraries missing DT_NEEDED and not containing undefined
non-weak symbols.
Bug: https://bugs.gentoo.org/516016
Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
| |
Do not report not respecting LDFLAGS for *.o files with
__gentoo_check_ldflags__ symbol.
Bug: https://bugs.gentoo.org/686356
Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
| |
Bug: https://bugs.gentoo.org/685532
Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
| |
Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
| |
Closes: https://bugs.gentoo.org/662468
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
| |
It is more common in gentoo to see ${CATEGORY}/${PF} rather than ${PF}
followed by ${CATEGORY}.
Closes: https://github.com/gentoo/portage/pull/423
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
| |
Suggested-by: Pacho Ramos <pacho@gentoo.org>
Bug: https://bugs.gentoo.org/651678
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When trying to figure out why it took so long to do a no-op kernel
build (re-build when nothing changed) on Chrome OS, I tracked down one
slowdown to cros-kernel2_src_configure(). This function was taking
~900 ms to execute.
The bulk of that slowdown was in iterating over the list of config
fragments, specifically the "use ${fragment}" test. We currently have
77 fragments so we were effectively calling the "use" function 77
times.
Digging through the portage code, the slow part of the "use" function
was the block of code to confirm that you specified each USE flag in
your IUSE. Commenting out the whole "elif" block of code there sped
things up so that the entire cros-kernel2_src_configure() was now
taking ~130 ms. This means that each call to the "use" function was
taking about 10 ms.
The specific part of the test that was slow was testing against the
regular expression. It was specifically slow in the Chrome OS kernel
build because we inherit the "cros-board" eclass which populates a
huge number of boards in the USE flag, making the regular expression
totally unwieldly.
One way to speed this whole thing up is to use a bash associative
array. Unfortunately arrays can't come in through environment
variables, so we'll write a function that declares the array the first
time it's needed.
With this version of the code cros-kernel2_src_configure() now takes
~190 ms which seems like it's OK. AKA 77 checks against IUSE took 60
ms or less than 1 ms per check.
NOTE: to keep EAPI 4 and older working, we keep doing the regular
expression tests there, though we now do it in the __in_portage_iuse()
function. In at least one test the extra overhead of the function
made testing USE flags on EAPI 4 ~15% slower, but presumably this is
OK as we want to encourage folks to move to the newer EAPIs.
BUG=chromium:767073
TEST=Time some builds; confirm bad use flags still caught.
Change-Id: Ic74fa49bdf002399ba0d6c41f42d4632b07127a9
Reviewed-on: https://chromium-review.googlesource.com/1524641
Commit-Ready: Douglas Anderson <dianders@chromium.org>
Tested-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
See: https://chromium.googlesource.com/chromiumos/third_party/portage_tool/+/82a0776602df5707606de2099b93b8b7b1cc34a1
Bug: https://bugs.gentoo.org/680810
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the fallback from S to WORKDIR was made conditional in EAPI 4,
src_test() was originally omitted. This has been fixed retroactively
in PMS:
https://gitweb.gentoo.org/proj/pms.git/commit/?id=0038f90a942f0856ae2533b26f709002a3ec80ae
There should be no issues with backwards compatibility of existing
ebuilds. The feature is not used in the Gentoo repository. Plus, the
scenario is very unlikely, because in src_test the fallback to WORKDIR
could only happen for an ebuild that:
- Has no files in A to be unpacked.
- Doesn't define any of the unpack, prepare, configure, compile or
install phases (otherwise it would die in one of these phases).
Acked-by: Zac Medico <zmedico@gentoo.org>
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
|
|
|
|
|
|
| |
Bug: https://bugs.gentoo.org/677776
Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
| |
xdg_icon_cache_update
Bug: https://bugs.gentoo.org/677776
Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
|
| |
50gnome2-utils to 50xdg-utils.
No changes inside source code of this function.
Bug: https://bugs.gentoo.org/677776
Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
|
| |
The fcntl.ioctl call raises IOError, which is different from OSError
for python2. Use EnvironmentError for compatibility.
Bug: https://bugs.gentoo.org/675868
Reported-by: Ivan Ivanich <ivanich@ivanich.org.ua>
Fixes: ce0656337268 ("pid-sandbox: pid-ns-init TIOCSCTTY after setsid (bug 675868)")
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
| |
Set the controlling terminal to the stdout pty after calling setsid,
in order to avoid "No such device or address" ENXIO errors when
attempting to open /dev/tty.
Bug: https://bugs.gentoo.org/675868
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
|
| |
Drop permissions only for subprocess of pid-ns-init but not pid-ns-init
itself. With FEATURES="pid-sandbox userpriv", pid-ns-init should be
run with unchanged permissions (usually UID=0, GID=0).
Bug: https://bugs.gentoo.org/675868
Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
| |
Use setsid to isolate the parent process from signals sent
to the process group, and forward signals to the entire
process group with kill(0, signum).
Bug: https://bugs.gentoo.org/675870
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use local -x ECLASS, and also make __export_funcs_var a local variable,
since this is simpler than managing these variables as globals
(eliminates PECLASS and prev_export_funcs_var variables). As an
additional benefit, this prevents interference from ebuild variables
as reported in bug 656354 for the ECLASS variable.
Bug: https://bugs.gentoo.org/656354
Bug: https://bugs.gentoo.org/676014
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
| |
Fixes: fb2459330cf2 ("ebuild.sh: Completely ban external commands in global scope")
Reported-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use subprocess.Popen to correctly configure the signal disposition
of the child process, since os.fork leaves the signal disposition
in a state which may be inappropriate for various signals including
SIGPIPE, SIGQUIT, SIGTERM, and SIGINT. For python implementations
other that CPython >= 3, use preexec_fn to manually configure the
signal disposition (I have found that this is necessary for CPython
2.7 and all PyPy versions tested, including PyPy3).
Bug: https://bugs.gentoo.org/675828
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
| |
Fixes: 60ee4deefb70 ("Refactor bashrc scripts sourcing")
Closes: https://github.com/gentoo/portage/pull/400
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
| |
asyncio.Task.current_task()
PendingDeprecationWarning: Task.current_task() is deprecated, use asyncio.current_task() instead
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Execute pid-ns-init as the first fork after unshare, as
required for it to have pid 1 and become the default reaper
of orphaned descendant processes. In _exec, exec a separate
pid-ns-init process to behave as a supervisor which will
forward signals to init and forward exit status to the parent
process.
Fixes: a75d5546e3a4 ("Introduce a tiny init replacement for inside pid namespace")
Bug: https://bugs.gentoo.org/675312
Reviewed-by: Brian Dolbec <dolsen@gentoo.org>
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
| |
The canonicalize function is required by install-qa-check.d/05prefix.
Fixes: aa0a94198794 ("ecompress: Replace with implementation from portage[mgorny]")
Bug: https://bugs.gentoo.org/670484
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
| |
Closes: https://github.com/gentoo/portage/pull/395
Signed-off-by: Kewl Fft <kewl@alto.eu.org>
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
In ebuild.sh, grant sandbox write access directly to
${PORTAGE_TMPDIR}/portage, since write access to ${PORTAGE_TMPDIR}
itself is not needed. Also, remove the _check_temp_dir symlink
check from bug 378403, since a symlink is permissible if write
access is granted directly to ${PORTAGE_TMPDIR}/portage.
Bug: https://bugs.gentoo.org/673738
Bug: https://bugs.gentoo.org/378403
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
| |
The _portage_reinstall_ pattern is now redundant because it would match
${PORTAGE_TMPDIR}/portage/._portage_reinstall_.*/ebuild-helpers* paths
that */portage/*/ebuild-helpers* would also match.
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
| |
In case PORTAGE_OVERRIDE_EPREFIX is modified in the environment,
the actual ebuild-helpers PATH will not match PORTAGE_OVERRIDE_EPREFIX.
Use the same ebuild-helpers pattern as the portageq wrapper script
since daeb75b345c4433218ab9e7a5319e8914092f048.
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
| |
In case PORTAGE_OVERRIDE_EPREFIX is modified in the environment,
the actual ebuild-helpers PATH will not match PORTAGE_OVERRIDE_EPREFIX.
Closes: https://github.com/gentoo/portage/pull/389
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
| |
Closes: https://github.com/gentoo/portage/pull/381
Signed-off-by: Kewl Fft <kewl@alto.eu.org>
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
|
| |
Use the @uses_configroot decorator to make portage get_repos
respect the <eroot> parameter, like portage repos_config since
commit 382f4be415394886026ccd5dcd08ca96ecda31fa. Apply the same
fix to master_repositories and master_repos.
Bug: https://bugs.gentoo.org/670082
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
| |
Reviewed-by: Zac Medico <zmedico@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
|
|
|
|
| |
Reviewed-by: Zac Medico <zmedico@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
save_IFS and restore_IFS are the only aliases that Portage defines,
and they are used exactly once. Rewrite __source_all_bashrcs() not to
depend on them, and remove their definitions.
The intention is to drop the expand_aliases shell option at some time
in the future.
Acked-by: Zac Medico <zmedico@gentoo.org>
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Similarly to FEATURES=binpkg-docompress, implement
FEATURES=binpkg-dostrip that controls whether stripping occurs before or
after building the binary package.
This makes it possible to build binary packages with some debug
information that is stripped upon installing. Afterwards, the binary
packages can be reinstalled with debug info (either via nostrip or
splitdebug). Real usability of this feature will be limited by
optimization levels applied but still, it's better than nothing.
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Reviewed-by: Zac Medico <zmedico@gentoo.org>
|