From 1bbd1592c89a433e1a0501d582652d54d367ca53 Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Fri, 11 Nov 2011 10:40:09 +0100 Subject: os-posix: Plug fd leak in qemu_create_pidfile() Spotted by Coverity. Signed-off-by: Markus Armbruster Signed-off-by: Anthony Liguori --- os-posix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/os-posix.c b/os-posix.c index dbf3b240f..dc4a6bb3f 100644 --- a/os-posix.c +++ b/os-posix.c @@ -372,13 +372,16 @@ int qemu_create_pidfile(const char *filename) return -1; } if (lockf(fd, F_TLOCK, 0) == -1) { + close(fd); return -1; } len = snprintf(buffer, sizeof(buffer), FMT_pid "\n", getpid()); if (write(fd, buffer, len) != len) { + close(fd); return -1; } + close(fd); return 0; } -- cgit v1.2.3-65-gdbad