summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndreas Sturmlechner <asturm@gentoo.org>2019-04-27 20:45:19 +0200
committerAndreas Sturmlechner <asturm@gentoo.org>2019-04-27 22:51:36 +0200
commit1c974e92352cf577f88b1c214ec6b29ff20f1cd3 (patch)
tree175bf961a7e1b26f97991fedfa9c5b83c167d3c7 /kde-frameworks/kpackage/files
parentsys-libs/binutils-libs: stable 2.31.1-r4 for ia64, bug #681682 (diff)
downloadgentoo-1c974e92352cf577f88b1c214ec6b29ff20f1cd3.tar.gz
gentoo-1c974e92352cf577f88b1c214ec6b29ff20f1cd3.tar.bz2
gentoo-1c974e92352cf577f88b1c214ec6b29ff20f1cd3.zip
kde-frameworks/kpackage: Fix runtime crash
Package-Manager: Portage-2.3.65, Repoman-2.3.12 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Diffstat (limited to 'kde-frameworks/kpackage/files')
-rw-r--r--kde-frameworks/kpackage/files/kpackage-5.57.0-runtime-crashfix.patch42
1 files changed, 42 insertions, 0 deletions
diff --git a/kde-frameworks/kpackage/files/kpackage-5.57.0-runtime-crashfix.patch b/kde-frameworks/kpackage/files/kpackage-5.57.0-runtime-crashfix.patch
new file mode 100644
index 00000000000..5d13d3f8c3a
--- /dev/null
+++ b/kde-frameworks/kpackage/files/kpackage-5.57.0-runtime-crashfix.patch
@@ -0,0 +1,42 @@
+From c3e896e02f9a8dc92d6e26cdbc87fe5c6b9cf3bf Mon Sep 17 00:00:00 2001
+From: David Faure <faure@kde.org>
+Date: Sun, 14 Apr 2019 19:44:50 +0200
+Subject: Don't use qAsConst over a temporary variable
+
+Summary:
+(will crash because the temporary will be destroyed before being used)
+
+Detected with
+ ag -sr qAsConst'\([^)]*\(' .
+
+Test Plan: builds
+
+Reviewers: mlaurent, cfeck, apol
+
+Reviewed By: mlaurent
+
+Subscribers: kde-frameworks-devel
+
+Tags: #frameworks
+
+Differential Revision: https://phabricator.kde.org/D20552
+---
+ src/kpackage/package.cpp | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/src/kpackage/package.cpp b/src/kpackage/package.cpp
+index 130eec6..801f1c2 100644
+--- a/src/kpackage/package.cpp
++++ b/src/kpackage/package.cpp
+@@ -429,7 +429,8 @@ QStringList Package::entryList(const QByteArray &key) const
+ QStringList list;
+ for (const QString &prefix : qAsConst(d->contentsPrefixPaths)) {
+ //qCDebug(KPACKAGE_LOG) << " looking in" << prefix;
+- for (const QString &path : qAsConst(it.value().paths)) {
++ const QStringList paths = it.value().paths;
++ for (const QString &path : paths) {
+ //qCDebug(KPACKAGE_LOG) << " looking in" << path;
+ if (it.value().directory) {
+ //qCDebug(KPACKAGE_LOG) << "it's a directory, so trying out" << d->path + prefix + path;
+--
+cgit v1.1