summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* estack.eclass: Fix typo in comment.Ulrich Müller2019-11-261-1/+1
| | | | | Fixes: d2cb9490dbee48a32f196d1aa80d7356a99d9fd8 Signed-off-by: Ulrich Müller <ulm@gentoo.org>
* estack.eclass: Drop isdigit function.Ulrich Müller2019-11-261-13/+2
| | | | | | | It isn't (and never was) used by anything else in the tree. Inline its only usage in evar_pop() and drop the function. Signed-off-by: Ulrich Müller <ulm@gentoo.org>
* estack.eclass: Properly restore shopt options.Ulrich Müller2019-11-261-4/+5
| | | | | | | | | | | | | | | | | Calling "eshopts_push; eshopts_pop" makes Portage report a QA issue: * QA Notice: Global shell options changed and were not restored while calling 'src_prepare' This is caused by some side effect in bash, by which disabling the "posix" option (even if it was already disabled before) in a non-interactive shell also disables the "expand_aliases" option. Work around the problem by always saving and restoring both "set -o" and "shopt" option sets. Also fix "estack_push -s" which should not execute shopt when called without further parameters. Closes: https://bugs.gentoo.org/662586 Signed-off-by: Ulrich Müller <ulm@gentoo.org>
* estack.eclass: Use 'shopt -p -o' to restore 'set' flagsMichał Górny2017-04-141-7/+2
| | | | | | Use 'shopt -p -o' to obtain the current set of 'set' flags, and to restore them on popping. Unlike $-, it is output in command form (alike 'shopt -p'), removing the need for separate logic in eshopts_pop.
* estack.eclass: Split estack* logic from eutilsMichał Górny2017-03-181-0/+217
Split the estack_* and related functions from eutils into a dedicated estack.eclass. Those functions have significant complexity and are not used frequently, therefore they benefit from having a separate file and an explicit dedicated maintainer. The new eclass is implicitly inherited by eutils to preserve compatibility. However, the inherit will be removed in EAPI 7, and the ebuilds should switch to using estack directly. Thanks to Ulrich Müller for doing the research on this.