From 94478827aab63d2e2321f0ca9ec5553718798e60 Mon Sep 17 00:00:00 2001 From: Aleix Pol Date: Wed, 10 Mar 2021 21:48:53 +0100 Subject: [PATCH] Only turn http[s] links into clickable links CVE-2021-28117 (cherry picked from commit d375031ff0262cedac7d6ee2b26d6a164ddebb67) --- libdiscover/backends/KNSBackend/KNSResource.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libdiscover/backends/KNSBackend/KNSResource.cpp b/libdiscover/backends/KNSBackend/KNSResource.cpp index 4394d5df..f7670c55 100644 --- a/libdiscover/backends/KNSBackend/KNSResource.cpp +++ b/libdiscover/backends/KNSBackend/KNSResource.cpp @@ -87,7 +87,7 @@ QString KNSResource::longDescription() ret.remove(QRegularExpression(QStringLiteral("\\[\\/?[a-z]*\\]"))); // Find anything that looks like a link (but which also is not some html // tag value or another already) and make it a link - static const QRegularExpression urlRegExp(QStringLiteral("(^|\\s)([-a-zA-Z0-9@:%_\\+.~#?&//=]{2,256}\\.[a-z]{2,4}\\b(\\/[-a-zA-Z0-9@:;%_\\+.~#?&//=]*)?)"), QRegularExpression::CaseInsensitiveOption); + static const QRegularExpression urlRegExp(QStringLiteral("(^|\\s)(http[-a-zA-Z0-9@:%_\\+.~#?&//=]{2,256}\\.[a-z]{2,4}\\b(\\/[-a-zA-Z0-9@:;%_\\+.~#?&//=]*)?)"), QRegularExpression::CaseInsensitiveOption); ret.replace(urlRegExp, QStringLiteral("\\2")); return ret; } -- GitLab