From d9f3fa0ede556c6a751a8ca6c8bc37e769715233 Mon Sep 17 00:00:00 2001 From: Christian Beier Date: Mon, 19 Aug 2019 22:32:25 +0200 Subject: [PATCH 3/3] rfbserver: don't leak stack memory to the remote Thanks go to Pavel Cheremushkin of Kaspersky for reporting. --- server/libvncserver/rfbserver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/server/libvncserver/rfbserver.c b/server/libvncserver/rfbserver.c index 2224edb..ca4f59b 100644 --- a/server/libvncserver/rfbserver.c +++ b/server/libvncserver/rfbserver.c @@ -1565,6 +1565,8 @@ rfbSendServerCutText(rfbScreenInfoPtr rfbScreen,char *str, int len) rfbServerCutTextMsg sct; rfbClientIteratorPtr iterator; + memset((char *)&sct, 0, sizeof(sct)); + iterator = rfbGetClientIterator(rfbScreen); while ((cl = rfbClientIteratorNext(iterator)) != NULL) { /* Client is not authenticated, ignore. See GNOME bug 678434. */ -- 2.20.1