From 0e93784410db711eef67fa2a56b0ec4bc4b5e08d Mon Sep 17 00:00:00 2001 From: Bastien Nocera Date: Sun, 15 Feb 2015 18:43:49 +0100 Subject: [PATCH] Add a note about ISO image magic And the fact that we cannot implement it here. --- HACKING | 3 +++ freedesktop.org.xml.in | 1 + 2 files changed, 4 insertions(+) diff --git a/HACKING b/HACKING index 260025b..370fb68 100644 --- a/HACKING +++ b/HACKING @@ -10,6 +10,9 @@ A few ground rules for people interested in adding new mime-types. * Mime-types/file formats proprietary to one application should only be added to a private .xml file and be bundled with the application itself +* Magic offset must be as small as possible. For example, the worst case + scenario for ISO images is 32k inside the file. This is too big for a sniff + buffer, especially on remote locations. Avoid those. * No commits should be done that break the test suite, or the test suite test in question should be amended, and reason for the changes clearly documented in the commit message diff --git a/freedesktop.org.xml.in b/freedesktop.org.xml.in index 7321d40..093c260 100644 --- a/freedesktop.org.xml.in +++ b/freedesktop.org.xml.in @@ -1514,6 +1514,7 @@ command to generate the output files. <_comment>raw CD image + -- 2.4.1