aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZac Medico <zmedico@gentoo.org>2011-10-20 07:16:50 -0700
committerZac Medico <zmedico@gentoo.org>2011-10-20 07:16:50 -0700
commita5968f7d9b1c17568fba27f7b7fd284b9431802d (patch)
tree01c1edd4fc79cc406e4f606eda7ff4687bd24c95
parentresolver/output: use set for myfetchlist hashing (diff)
downloadportage-a5968f7d9b1c17568fba27f7b7fd284b9431802d.tar.gz
portage-a5968f7d9b1c17568fba27f7b7fd284b9431802d.tar.bz2
portage-a5968f7d9b1c17568fba27f7b7fd284b9431802d.zip
misc-functions.sh: move sleep out of loop
Having sleep in the world-writable loop causes riduculous delays for prefix users with exotic filesystem constraints (like a FAT filesystem mounted with umask=000).
-rwxr-xr-xbin/misc-functions.sh4
1 files changed, 2 insertions, 2 deletions
diff --git a/bin/misc-functions.sh b/bin/misc-functions.sh
index b3e62c5fe..0d2d20689 100755
--- a/bin/misc-functions.sh
+++ b/bin/misc-functions.sh
@@ -166,14 +166,14 @@ install_qa_check() {
fi
# Now we look for all world writable files.
- local i
+ local i=
for i in $(find "${D}/" -type f -perm -2); do
vecho "QA Security Notice:"
vecho "- ${i:${#D}:${#i}} will be a world writable file."
vecho "- This may or may not be a security problem, most of the time it is one."
vecho "- Please double check that $PF really needs a world writeable bit and file bugs accordingly."
- sleep 1
done
+ [[ -n ${i} ]] && sleep 1
if type -P scanelf > /dev/null && ! has binchecks ${RESTRICT}; then
local qa_var insecure_rpath=0 tmp_quiet=${PORTAGE_QUIET}