aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZac Medico <zmedico@gentoo.org>2010-10-22 03:09:55 -0700
committerZac Medico <zmedico@gentoo.org>2010-10-22 03:09:55 -0700
commit292a277974fe1223bfa956243ac1a2bde1e20c42 (patch)
tree0c79b154a176a1aee8928e6702fc43b34a7e1b44 /pym/_emerge/EbuildFetcher.py
parentEbuildFetcher: Use fork for better performance. (diff)
downloadportage-292a277974fe1223bfa956243ac1a2bde1e20c42.tar.gz
portage-292a277974fe1223bfa956243ac1a2bde1e20c42.tar.bz2
portage-292a277974fe1223bfa956243ac1a2bde1e20c42.zip
EbuildFetcher: close uneeded fds in subprocess
Diffstat (limited to 'pym/_emerge/EbuildFetcher.py')
-rw-r--r--pym/_emerge/EbuildFetcher.py11
1 files changed, 1 insertions, 10 deletions
diff --git a/pym/_emerge/EbuildFetcher.py b/pym/_emerge/EbuildFetcher.py
index b1a10d900..1abe846d7 100644
--- a/pym/_emerge/EbuildFetcher.py
+++ b/pym/_emerge/EbuildFetcher.py
@@ -85,16 +85,7 @@ class EbuildFetcher(SpawnProcess):
portage.process.spawned_pids.append(pid)
return [pid]
- # Set up the command's pipes.
- my_fds = {}
- # To protect from cases where direct assignment could
- # clobber needed fds ({1:2, 2:1}) we first dupe the fds
- # into unused fds.
- for fd in fd_pipes:
- my_fds[fd] = os.dup(fd_pipes[fd])
- # Then assign them to what they should be.
- for fd in my_fds:
- os.dup2(my_fds[fd], fd)
+ portage.process._setup_pipes(fd_pipes)
# Force consistent color output, in case we are capturing fetch
# output through a normal pipe due to unavailability of ptys.