aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichał Górny <mgorny@gentoo.org>2010-10-24 10:18:23 +0200
committerZac Medico <zmedico@gentoo.org>2010-10-24 11:34:12 -0700
commitb6a70de78497a3e9e62d524ec3e355355b913efb (patch)
treeeeb289b3fc06fcbad321f47eaf064850b7a517f7 /pym/_emerge/actions.py
parentSimplify debug-print*() functions code. (diff)
downloadportage-b6a70de78497a3e9e62d524ec3e355355b913efb.tar.gz
portage-b6a70de78497a3e9e62d524ec3e355355b913efb.tar.bz2
portage-b6a70de78497a3e9e62d524ec3e355355b913efb.zip
Cleanup CVS calls in 'sync' action.
Use 'exec' to avoid unnecessary redundant processes. Update the checkout code to use spawn_bash() like update does.
Diffstat (limited to 'pym/_emerge/actions.py')
-rw-r--r--pym/_emerge/actions.py6
1 files changed, 4 insertions, 2 deletions
diff --git a/pym/_emerge/actions.py b/pym/_emerge/actions.py
index 5ac676d91..0ab3bda6a 100644
--- a/pym/_emerge/actions.py
+++ b/pym/_emerge/actions.py
@@ -2396,7 +2396,9 @@ def action_sync(settings, trees, mtimedb, myopts, myaction):
"!!! existing '%s' directory; exiting.\n" % myportdir)
sys.exit(1)
del e
- if portage.spawn("cd "+cvsdir+"; cvs -z0 -d "+cvsroot+" co -P gentoo-x86",settings,free=1):
+ if portage.spawn_bash("cd %s; exec cvs -z0 -d %s co -P gentoo-x86" % \
+ (portage._shell_quote(cvsdir), portage._shell_quote(cvsroot)),
+ settings, free=1):
print("!!! cvs checkout error; exiting.")
sys.exit(1)
os.rename(os.path.join(cvsdir, "gentoo-x86"), myportdir)
@@ -2404,7 +2406,7 @@ def action_sync(settings, trees, mtimedb, myopts, myaction):
#cvs update
print(">>> Starting cvs update with "+syncuri+"...")
retval = portage.process.spawn_bash(
- "cd %s; cvs -z0 -q update -dP" % \
+ "cd %s; exec cvs -z0 -q update -dP" % \
(portage._shell_quote(myportdir),), **spawn_kwargs)
if retval != os.EX_OK:
sys.exit(retval)