diff options
| author |   Kent Fredric <kentnl@gentoo.org> | 2017-09-16 08:54:10 +1200 |
|---|---|---|
| committer | Kent Fredric <kentnl@gentoo.org> | 2017-09-17 12:39:37 +1200 |
| commit | 11e52068ff5158fdf6aaae7482441b306748ef45 (patch) | |
| tree | 4772bae72d5c1aa204e599f13827310a3ae1d196 | |
| parent | perl-functions.eclass: Add a new (not in ::gentoo) perl_check_eapi function (diff) | |
| download | perl-overlay-11e52068.tar.gz perl-overlay-11e52068.tar.bz2 perl-overlay-11e52068.zip | |
perl-module.eclass: run perl_check_eapi in src_configure
I had to think long and hard about where to put this :/
Putting it where it should be logically:
* pkg_setup:
Downsides: new phase function people won't expect to be there
Downsides: makes extra work for the common definition of pkg_setup
* src_unpack:
Downsides: Same as pkg_setup
* src_pretend:
Downsides: Too early
Downsides: makes all perl modules slow to install
* global
Downsides: makes metadata collection very slow
Downsides: risks running too much code in global scope
* src_configre:
Downsides: risks only discovering the bug after shipping
However, the case of the last one dictates that the maintainer did
significant changes, and then never even compile tested it.
Maintainer rightly gets a rap over the knuckles and such things should
never be stable
| -rw-r--r-- | eclass/perl-module.eclass | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/eclass/perl-module.eclass b/eclass/perl-module.eclass index 3b4971389..5789d96bf 100644 --- a/eclass/perl-module.eclass +++ b/eclass/perl-module.eclass @@ -228,6 +228,7 @@ perl-module_src_configure() { fi SRC_PREP="yes" + perl_check_eapi perl_check_env perl_set_version |