diff options
| author |   Zac Medico <zmedico@gentoo.org> | 2018-11-18 22:38:21 -0800 |
|---|---|---|
| committer | Zac Medico <zmedico@gentoo.org> | 2018-11-18 22:42:06 -0800 |
| commit | 58eb01022e604b0a538b9d67bd64daa44da9f94a (patch) | |
| tree | 284de3f05122201d7624417871585d6d98520d24 | |
| parent | Introduce a tiny init replacement for inside pid namespace (diff) | |
| download | portage-58eb0102.tar.gz portage-58eb0102.tar.bz2 portage-58eb0102.zip | |
Revert "fetch: check DISTDIR write access as fetch user (bug 601252)"
This reverts commit 4264ac4b07c4555eb5db2ab21288dba05a7f4b6d.
Dropping privileges for the access call is not useful by itself,
since lock and unlink calls do not drop privileges yet. We might
decide to drop privileges for the entire fetch function call.
Bug: https://bugs.gentoo.org/601252
Signed-off-by: Zac Medico <zmedico@gentoo.org>
| -rw-r--r-- | lib/portage/package/ebuild/fetch.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/portage/package/ebuild/fetch.py b/lib/portage/package/ebuild/fetch.py index 7ec7fe05e..0431e11ea 100644 --- a/lib/portage/package/ebuild/fetch.py +++ b/lib/portage/package/ebuild/fetch.py @@ -543,7 +543,7 @@ def fetch(myuris, mysettings, listonly=0, fetchonly=0, if can_fetch and \ not fetch_to_ro and \ - _spawn_fetch(mysettings, ['test', '-w', mysettings["DISTDIR"]]) != os.EX_OK: + not os.access(mysettings["DISTDIR"], os.W_OK): writemsg(_("!!! No write access to '%s'\n") % mysettings["DISTDIR"], noiselevel=-1) can_fetch = False |