blob: a160436aee175f96c59df8ffbb61a0a7f305017c (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
|
# Check for important gcc warning
gcc_warn_check() {
local f
# Evaluate misc gcc warnings
if [[ -n ${PORTAGE_LOG_FILE} && -r ${PORTAGE_LOG_FILE} ]] ; then
# In debug mode, this variable definition and corresponding grep calls
# will produce false positives if they're shown in the trace.
local reset_debug=0
if [[ ${-/x/} != $- ]] ; then
set +x
reset_debug=1
fi
local m msgs=(
# only will and does, no might :)
'warning: .*will.*\[-Wstrict-aliasing\]'
'warning: .*does.*\[-Wstrict-aliasing\]'
# implicit declaration of function ‘...’
'warning: .*\[-Wimplicit-function-declaration\]'
# with -Wall, goes in pair with -Wimplicit-function-declaration
# but without -Wall, we need to assert for it alone
'warning: .*incompatible implicit declaration of built-in function'
# 'is used uninitialized in this function' and some more
'warning: .*\[-Wuninitialized\]'
# comparisons like ‘X<=Y<=Z’ do not have their mathematical meaning
'warning: .*mathematical meaning*\[-Wparentheses\]'
# null argument where non-null required
'warning: .*\[-Wnonnull\]'
# array subscript is above/below/outside array bounds
'warning: .*\[-Warray-bounds\]'
# attempt to free a non-heap object
'warning: .*\[-Wfree-nonheap-object\]'
# those three do not have matching -W flags, it seems
'warning: .*will always overflow destination buffer'
'warning: .*assuming pointer wraparound does not occur'
'warning: .*escape sequence out of range'
# left-hand operand of comma expression has no effect
'warning: .*left.*comma.*\[-Wunused-value\]'
# converting to non-pointer type ... from NULL and likes
'warning: .*\[-Wconversion-null\]'
# NULL used in arithmetic
'warning: .*NULL.*\[-Wpointer-arith\]'
# pointer to a function used in arithmetic and likes
'warning: .*function.*\[-Wpointer-arith\]'
# the address of ... will never be NULL and likes
# (uses of function refs & string constants in conditionals)
'warning: .*\[-Waddress\]'
# outdated?
'warning: .*too few arguments for format'
# format ... expects a matching ... argument
# (iow, too few arguments for format in new wording :))
'warning: .*matching.*\[-Wformat=\]'
# function returns address of local variable
'warning: .*\[-Wreturn-local-addr\]'
# argument to sizeof ... is the same expression as the source
'warning: .*\[-Wsizeof-pointer-memaccess\]'
# iteration invokes undefined behavior
'warning: .*\[-Waggressive-loop-optimizations\]'
# this may be valid code :/
#': warning: multi-character character constant'
# need to check these two ...
#': warning: assuming signed overflow does not occur when'
#': warning: comparison with string literal results in unspecified behav'
# yacc/lex likes to trigger this one
#': warning: extra tokens at end of .* directive'
# only gcc itself triggers this ?
#': warning: .*noreturn.* function does return'
# these throw false positives when 0 is used instead of NULL
#': warning: missing sentinel in function call'
#': warning: not enough variable arguments to fit a sentinel'
)
# join all messages into one grep-expression
local joined_msgs
printf -v joined_msgs '%s|' "${msgs[@]}"
joined_msgs=${joined_msgs%|}
local abort="no"
local grep_cmd=grep
[[ $PORTAGE_LOG_FILE = *.gz ]] && grep_cmd=zgrep
# Force C locale to work around slow multibyte locales. #160234
# Force text mode as newer grep will treat non-ASCII (e.g. UTF-8) as
# binary when we run in the C locale.
f=$(LC_CTYPE=C LC_COLLATE=C "${grep_cmd}" -E -a "${joined_msgs}" "${PORTAGE_LOG_FILE}" | uniq)
if [[ -n ${f} ]] ; then
abort="yes"
# for now, don't make this fatal (see bug #337031)
#if [[ ${f} == *'will always overflow destination buffer'* ]]; then
# always_overflow=yes
#fi
if [[ $always_overflow = yes ]] ; then
eerror
eerror "QA Notice: Package triggers severe warnings which indicate that it"
eerror " may exhibit random runtime failures."
eerror
eerror "${f}"
eerror
eerror " Please file a bug about this at http://bugs.gentoo.org/"
eerror " with the maintainer of the package."
eerror
else
__vecho -ne '\n'
eqawarn "QA Notice: Package triggers severe warnings which indicate that it"
eqawarn " may exhibit random runtime failures."
eqawarn "${f}"
__vecho -ne '\n'
fi
fi
local cat_cmd=cat
[[ $PORTAGE_LOG_FILE = *.gz ]] && cat_cmd=zcat
[[ $reset_debug = 1 ]] && set -x
# Use safe cwd, avoiding unsafe import for bug #469338.
f=$(cd "${PORTAGE_PYM_PATH}" ; $cat_cmd "${PORTAGE_LOG_FILE}" | \
"${PORTAGE_PYTHON:-/usr/bin/python}" "$PORTAGE_BIN_PATH"/check-implicit-pointer-usage.py || die "check-implicit-pointer-usage.py failed")
if [[ -n ${f} ]] ; then
# In the future this will be a forced "die". In preparation,
# increase the log level from "qa" to "eerror" so that people
# are aware this is a problem that must be fixed asap.
# just warn on 32bit hosts but bail on 64bit hosts
case ${CHOST} in
alpha*|hppa64*|ia64*|powerpc64*|mips64*|sparc64*|sparcv9*|x86_64*) gentoo_bug=yes ;;
esac
abort=yes
if [[ $gentoo_bug = yes ]] ; then
eerror
eerror "QA Notice: Package triggers severe warnings which indicate that it"
eerror " will almost certainly crash on 64bit architectures."
eerror
eerror "${f}"
eerror
eerror " Please file a bug about this at http://bugs.gentoo.org/"
eerror " with the maintainer of the package."
eerror
else
__vecho -ne '\n'
eqawarn "QA Notice: Package triggers severe warnings which indicate that it"
eqawarn " will almost certainly crash on 64bit architectures."
eqawarn "${f}"
__vecho -ne '\n'
fi
fi
if [[ ${abort} == "yes" ]] ; then
if [[ $gentoo_bug = yes || $always_overflow = yes ]] ; then
die "install aborted due to severe warnings shown above"
else
echo "Please do not file a Gentoo bug and instead" \
"report the above QA issues directly to the upstream" \
"developers of this software." | fmt -w 70 | \
while read -r line ; do eqawarn "${line}" ; done
eqawarn "Homepage: ${HOMEPAGE}"
has stricter ${FEATURES} && \
die "install aborted due to severe warnings shown above"
fi
fi
fi
}
gcc_warn_check
: # guarantee successful exit
# vim:ft=sh
|
GitWeb