summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobin H. Johnson <robbat2@gentoo.org>2019-04-12 00:21:25 -0700
committerRobin H. Johnson <robbat2@gentoo.org>2019-04-12 00:23:50 -0700
commitd25a7e5e0878baab48f80f7f6b971b61afd65f47 (patch)
tree759c4317ca044209d8a431b32cd9e6add163b89d /dev-vcs/git/files/git-2.21.0-quiet-submodules-testcase.patch
parentapp-text/asciidoc: stable 8.6.10 for sparc, bug #641648 (diff)
downloadgentoo-d25a7e5e0878baab48f80f7f6b971b61afd65f47.tar.gz
gentoo-d25a7e5e0878baab48f80f7f6b971b61afd65f47.tar.bz2
gentoo-d25a7e5e0878baab48f80f7f6b971b61afd65f47.zip
dev-vcs/git: fix noisy git-submodule-foreach regression
Fix output regression upstream where: 'git submodule foreach --quiet git pull --quiet origin master >/dev/null' Still gives output because foreach swallows some options to the per-submodule command. Package-Manager: Portage-2.3.62, Repoman-2.3.12 Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
Diffstat (limited to 'dev-vcs/git/files/git-2.21.0-quiet-submodules-testcase.patch')
-rw-r--r--dev-vcs/git/files/git-2.21.0-quiet-submodules-testcase.patch38
1 files changed, 38 insertions, 0 deletions
diff --git a/dev-vcs/git/files/git-2.21.0-quiet-submodules-testcase.patch b/dev-vcs/git/files/git-2.21.0-quiet-submodules-testcase.patch
new file mode 100644
index 000000000000..0874ea9352e9
--- /dev/null
+++ b/dev-vcs/git/files/git-2.21.0-quiet-submodules-testcase.patch
@@ -0,0 +1,38 @@
+From a57994f2d78134936521375ba9798a1b7418e230 Mon Sep 17 00:00:00 2001
+From: "Robin H. Johnson" <robbat2@gentoo.org>
+Date: Fri, 12 Apr 2019 00:00:07 -0700
+Subject: [PATCH] submodule foreach: test foreach option swallowing
+
+Add a testcase for submodule foreach option parsing not knowing where to
+stop taking options, and accidently removing options intended for
+foreach target commands.
+
+CC: Duy Nguyen <pclouds@gmail.com>
+CC: Prathamesh Chavan <pc44800@gmail.com>
+Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
+---
+ t/t7407-submodule-foreach.sh | 10 ++++++++++
+ 1 file changed, 10 insertions(+)
+
+diff --git a/t/t7407-submodule-foreach.sh b/t/t7407-submodule-foreach.sh
+index 77729ac4aa..706ae762e0 100755
+--- a/t/t7407-submodule-foreach.sh
++++ b/t/t7407-submodule-foreach.sh
+@@ -411,4 +411,14 @@ test_expect_success 'multi-argument command passed to foreach is not shell-evalu
+ test_cmp expected actual
+ '
+
++test_expect_success 'option-like arguments passed to foreach commands are not lost' '
++ (
++ cd super &&
++ git submodule foreach "echo be --quiet" > ../expected &&
++ git submodule foreach echo be --quiet > ../actual
++ ) &&
++ grep -sq -e "--quiet" expected &&
++ test_cmp expected actual
++'
++
+ test_done
+--
+2.21.0
+