*/*: [QA] Remove redundant `|| die` guards

* Since all ebuilds in the tree are EAPI>=4,
  `|| die` on builtin commands is redundant
  and dead code.

Closes: https://github.com/gentoo/gentoo/pull/13940
Reviewed-by: Ulrich Müller <ulm@gentoo.org>
Reviewed-by: Michał Górny <mgorny@gentoo.org>
Reviewed-by: Andreas K. Hüttel <dilfridge@gentoo.org>
Signed-off-by: David Seifert <soap@gentoo.org>

16 files changed, 35 insertions, 35 deletions

diff --git a/dev-vcs/bzr/bzr-2.7.0.ebuild b/dev-vcs/bzr/bzr-2.7.0.ebuild
index b873780921b1..a8a4e4ad7a78 100644
--- a/dev-vcs/bzr/bzr-2.7.0.ebuild
+++ b/dev-vcs/bzr/bzr-2.7.0.ebuild
@@ -82,10 +82,10 @@ python_install_all() {
 
 	if use doc; then
 		docinto developers
-		dodoc -r doc/developers/* || die
+		dodoc -r doc/developers/*
 		for doc in mini-tutorial tutorials user-{guide,reference}; do
 			docinto ${doc}
-			dodoc -r doc/en/${doc}/* || die
+			dodoc -r doc/en/${doc}/*
 		done
 	fi
 
diff --git a/dev-vcs/colorsvn/colorsvn-0.3.3.ebuild b/dev-vcs/colorsvn/colorsvn-0.3.3.ebuild
index 9ae642f733ff..18675f876ded 100644
--- a/dev-vcs/colorsvn/colorsvn-0.3.3.ebuild
+++ b/dev-vcs/colorsvn/colorsvn-0.3.3.ebuild
@@ -29,7 +29,7 @@ src_prepare() {
 
 src_compile() {
 	# bug 335134
-	emake -j1 || die
+	emake -j1
 }
 
 pkg_postinst() {
diff --git a/dev-vcs/cvsps/cvsps-2.2_beta1.ebuild b/dev-vcs/cvsps/cvsps-2.2_beta1.ebuild
index 3bbdb2bc9580..d5f68f1b445b 100644
--- a/dev-vcs/cvsps/cvsps-2.2_beta1.ebuild
+++ b/dev-vcs/cvsps/cvsps-2.2_beta1.ebuild
@@ -31,7 +31,7 @@ src_prepare() {
 }
 
 src_install() {
-	dobin cvsps || die
+	dobin cvsps
 	doman cvsps.1
 	dodoc README CHANGELOG
 }
diff --git a/dev-vcs/darcs/darcs-2.10.1.ebuild b/dev-vcs/darcs/darcs-2.10.1.ebuild
index da23ab5a4f93..40404e1b806d 100644
--- a/dev-vcs/darcs/darcs-2.10.1.ebuild
+++ b/dev-vcs/darcs/darcs-2.10.1.ebuild
@@ -94,5 +94,5 @@ src_install() {
 
 	# fixup perms in such an an awkward way
 	mv "${ED}/usr/share/man/man1/darcs.1" "${S}/darcs.1" || die "darcs.1 not found"
-	doman "${S}/darcs.1" || die "failed to register darcs.1 as a manpage"
+	doman "${S}/darcs.1"
 }
diff --git a/dev-vcs/darcs/darcs-2.10.3-r1.ebuild b/dev-vcs/darcs/darcs-2.10.3-r1.ebuild
index 4bbed55412c0..ecf1eda0544d 100644
--- a/dev-vcs/darcs/darcs-2.10.3-r1.ebuild
+++ b/dev-vcs/darcs/darcs-2.10.3-r1.ebuild
@@ -99,5 +99,5 @@ src_install() {
 
 	# fixup perms in such an an awkward way
 	mv "${ED}/usr/share/man/man1/darcs.1" "${S}/darcs.1" || die "darcs.1 not found"
-	doman "${S}/darcs.1" || die "failed to register darcs.1 as a manpage"
+	doman "${S}/darcs.1"
 }
diff --git a/dev-vcs/darcs/darcs-2.12.0.ebuild b/dev-vcs/darcs/darcs-2.12.0.ebuild
index 0d2bac89c4e3..160bcf620c14 100644
--- a/dev-vcs/darcs/darcs-2.12.0.ebuild
+++ b/dev-vcs/darcs/darcs-2.12.0.ebuild
@@ -93,5 +93,5 @@ src_install() {
 
 	# fixup perms in such an an awkward way
 	mv "${ED}/usr/share/man/man1/darcs.1" "${S}/darcs.1" || die "darcs.1 not found"
-	doman "${S}/darcs.1" || die "failed to register darcs.1 as a manpage"
+	doman "${S}/darcs.1"
 }
diff --git a/dev-vcs/darcs/darcs-2.8.4-r6.ebuild b/dev-vcs/darcs/darcs-2.8.4-r6.ebuild
index 85d765676744..41b7649deacc 100644
--- a/dev-vcs/darcs/darcs-2.8.4-r6.ebuild
+++ b/dev-vcs/darcs/darcs-2.8.4-r6.ebuild
@@ -121,7 +121,7 @@ src_install() {
 
 	# fixup perms in such an an awkward way
 	mv "${ED}/usr/share/man/man1/darcs.1" "${S}/darcs.1" || die "darcs.1 not found"
-	doman "${S}/darcs.1" || die "failed to register darcs.1 as a manpage"
+	doman "${S}/darcs.1"
 }
 
 pkg_postinst() {
diff --git a/dev-vcs/gitolite-gentoo/gitolite-gentoo-2.3.1-r1.ebuild b/dev-vcs/gitolite-gentoo/gitolite-gentoo-2.3.1-r1.ebuild
index 68d699eaea57..f4ed513d8334 100644
--- a/dev-vcs/gitolite-gentoo/gitolite-gentoo-2.3.1-r1.ebuild
+++ b/dev-vcs/gitolite-gentoo/gitolite-gentoo-2.3.1-r1.ebuild
@@ -39,7 +39,7 @@ src_install() {
 	local gl_bin="${D}/usr/bin"
 	gl_bin=${gl_bin/\/\//\/}
 
-	dodir /usr/share/gitolite/{conf,hooks} /usr/bin || die
+	dodir /usr/share/gitolite/{conf,hooks} /usr/bin
 
 	export PATH="${gl_bin}:${PATH}"
 	./src/gl-system-install ${gl_bin} \
@@ -49,13 +49,13 @@ src_install() {
 
 	rm "${D}"/usr/bin/*.pm
 	insinto "${VENDOR_LIB}"
-	doins src/*.pm || die
+	doins src/*.pm
 
 	dodoc README.mkd doc/*
 
 	if use contrib; then
 		insinto /usr/share/doc/${PF}
-		doins -r contrib/ || die
+		doins -r contrib/
 	fi
 
 	keepdir /var/lib/gitolite
diff --git a/dev-vcs/gitolite-gentoo/gitolite-gentoo-2.3.3-r1.ebuild b/dev-vcs/gitolite-gentoo/gitolite-gentoo-2.3.3-r1.ebuild
index f03af212c5f8..7445c714339b 100644
--- a/dev-vcs/gitolite-gentoo/gitolite-gentoo-2.3.3-r1.ebuild
+++ b/dev-vcs/gitolite-gentoo/gitolite-gentoo-2.3.3-r1.ebuild
@@ -39,7 +39,7 @@ src_install() {
 	local gl_bin="${D}/usr/bin"
 	gl_bin=${gl_bin/\/\//\/}
 
-	dodir /usr/share/gitolite/{conf,hooks} /usr/bin || die
+	dodir /usr/share/gitolite/{conf,hooks} /usr/bin
 
 	export PATH="${gl_bin}:${PATH}"
 	./src/gl-system-install ${gl_bin} \
@@ -49,13 +49,13 @@ src_install() {
 
 	rm "${D}"/usr/bin/*.pm
 	insinto "${VENDOR_LIB}"
-	doins src/*.pm || die
+	doins src/*.pm
 
 	dodoc README.mkd doc/*
 
 	if use contrib; then
 		insinto /usr/share/doc/${PF}
-		doins -r contrib/ || die
+		doins -r contrib/
 	fi
 
 	keepdir /var/lib/gitolite
diff --git a/dev-vcs/gitolite/gitolite-2.3.1-r1.ebuild b/dev-vcs/gitolite/gitolite-2.3.1-r1.ebuild
index ced390150277..8f8730181c0a 100644
--- a/dev-vcs/gitolite/gitolite-2.3.1-r1.ebuild
+++ b/dev-vcs/gitolite/gitolite-2.3.1-r1.ebuild
@@ -38,7 +38,7 @@ src_install() {
 	local gl_bin="${D}/usr/bin"
 	gl_bin=${gl_bin/\/\//\/}
 
-	dodir /usr/share/gitolite/{conf,hooks} /usr/bin || die
+	dodir /usr/share/gitolite/{conf,hooks} /usr/bin
 
 	# install using upstream method
 	export PATH="${gl_bin}:${PATH}"
@@ -49,13 +49,13 @@ src_install() {
 
 	rm "${D}"/usr/bin/*.pm
 	insinto "${VENDOR_LIB}"
-	doins src/*.pm || die
+	doins src/*.pm
 
 	dodoc README.mkd doc/*
 
 	if use contrib; then
 		insinto /usr/share/doc/${PF}
-		doins -r contrib/ || die
+		doins -r contrib/
 	fi
 
 	keepdir /var/lib/gitolite
diff --git a/dev-vcs/svn2git/svn2git-1.0.11-r1.ebuild b/dev-vcs/svn2git/svn2git-1.0.11-r1.ebuild
index 0fd35c4b742f..5df2948ca14b 100644
--- a/dev-vcs/svn2git/svn2git-1.0.11-r1.ebuild
+++ b/dev-vcs/svn2git/svn2git-1.0.11-r1.ebuild
@@ -47,7 +47,7 @@ src_configure() {
 src_install() {
 	einstalldocs
 	insinto /usr/share/${PN}/samples
-	doins samples/*.rules || die 'doins failed'
-	dobin svn-all-fast-export || die 'dobin failed'
-	dosym svn-all-fast-export /usr/bin/svn2git || die 'dosym failed'
+	doins samples/*.rules
+	dobin svn-all-fast-export
+	dosym svn-all-fast-export /usr/bin/svn2git
 }
diff --git a/dev-vcs/svn2git/svn2git-1.0.12.ebuild b/dev-vcs/svn2git/svn2git-1.0.12.ebuild
index ab7c62035ef9..f9d80383124c 100644
--- a/dev-vcs/svn2git/svn2git-1.0.12.ebuild
+++ b/dev-vcs/svn2git/svn2git-1.0.12.ebuild
@@ -41,7 +41,7 @@ src_configure() {
 src_install() {
 	einstalldocs
 	insinto /usr/share/${PN}/samples
-	doins samples/*.rules || die 'doins failed'
-	dobin svn-all-fast-export || die 'dobin failed'
-	dosym svn-all-fast-export /usr/bin/svn2git || die 'dosym failed'
+	doins samples/*.rules
+	dobin svn-all-fast-export
+	dosym svn-all-fast-export /usr/bin/svn2git
 }
diff --git a/dev-vcs/svn2git/svn2git-1.0.13-r1.ebuild b/dev-vcs/svn2git/svn2git-1.0.13-r1.ebuild
index dc22eca75dd5..7ff0f668cf45 100644
--- a/dev-vcs/svn2git/svn2git-1.0.13-r1.ebuild
+++ b/dev-vcs/svn2git/svn2git-1.0.13-r1.ebuild
@@ -45,7 +45,7 @@ src_configure() {
 src_install() {
 	einstalldocs
 	insinto /usr/share/${PN}/samples
-	doins samples/*.rules || die 'doins failed'
-	dobin svn-all-fast-export || die 'dobin failed'
-	dosym svn-all-fast-export /usr/bin/svn2git || die 'dosym failed'
+	doins samples/*.rules
+	dobin svn-all-fast-export
+	dosym svn-all-fast-export /usr/bin/svn2git
 }
diff --git a/dev-vcs/svn2git/svn2git-1.0.13.ebuild b/dev-vcs/svn2git/svn2git-1.0.13.ebuild
index ab7c62035ef9..f9d80383124c 100644
--- a/dev-vcs/svn2git/svn2git-1.0.13.ebuild
+++ b/dev-vcs/svn2git/svn2git-1.0.13.ebuild
@@ -41,7 +41,7 @@ src_configure() {
 src_install() {
 	einstalldocs
 	insinto /usr/share/${PN}/samples
-	doins samples/*.rules || die 'doins failed'
-	dobin svn-all-fast-export || die 'dobin failed'
-	dosym svn-all-fast-export /usr/bin/svn2git || die 'dosym failed'
+	doins samples/*.rules
+	dobin svn-all-fast-export
+	dosym svn-all-fast-export /usr/bin/svn2git
 }
diff --git a/dev-vcs/svn2git/svn2git-1.0.16.ebuild b/dev-vcs/svn2git/svn2git-1.0.16.ebuild
index eaaa32f003ea..0db87be987a4 100644
--- a/dev-vcs/svn2git/svn2git-1.0.16.ebuild
+++ b/dev-vcs/svn2git/svn2git-1.0.16.ebuild
@@ -41,7 +41,7 @@ src_configure() {
 src_install() {
 	einstalldocs
 	insinto /usr/share/${PN}/samples
-	doins samples/*.rules || die 'doins failed'
-	dobin svn-all-fast-export || die 'dobin failed'
-	dosym svn-all-fast-export /usr/bin/svn2git || die 'dosym failed'
+	doins samples/*.rules
+	dobin svn-all-fast-export
+	dosym svn-all-fast-export /usr/bin/svn2git
 }
diff --git a/dev-vcs/svn2git/svn2git-9999.ebuild b/dev-vcs/svn2git/svn2git-9999.ebuild
index 77393d1e3fbe..7f86d838d122 100644
--- a/dev-vcs/svn2git/svn2git-9999.ebuild
+++ b/dev-vcs/svn2git/svn2git-9999.ebuild
@@ -40,7 +40,7 @@ src_configure() {
 src_install() {
 	einstalldocs
 	insinto /usr/share/${PN}/samples
-	doins samples/*.rules || die 'doins failed'
-	dobin svn-all-fast-export || die 'dobin failed'
-	dosym svn-all-fast-export /usr/bin/svn2git || die 'dosym failed'
+	doins samples/*.rules
+	dobin svn-all-fast-export
+	dosym svn-all-fast-export /usr/bin/svn2git
 }