net-p2p/transmission: disable assertions by default

Upstream thinks assertions are only meant for "test builds".

Closes: https://bugs.gentoo.org/893870
Signed-off-by: Mike Gilbert <floppym@gentoo.org>

4 files changed, 17 insertions, 7 deletions

diff --git a/net-p2p/transmission/metadata.xml b/net-p2p/transmission/metadata.xml
index cd3c06fe292c..b53bce5e75af 100644
--- a/net-p2p/transmission/metadata.xml
+++ b/net-p2p/transmission/metadata.xml
@@ -10,6 +10,7 @@
 	</upstream>
 	<use>
 		<flag name="cli">Build command-line client</flag>
+		<flag name="debug">Enable assertions</flag>
 		<flag name="lightweight">Optimize transmission for low-resource systems (smaller cache size, prefer unencrypted peer connections, etc.)</flag>
 		<flag name="mbedtls">Use mbed TLS instead of OpenSSL</flag>
 	</use>
diff --git a/net-p2p/transmission/transmission-3.00-r5.ebuild b/net-p2p/transmission/transmission-3.00-r6.ebuild
index bcda90af6099..820cbc376d71 100644
--- a/net-p2p/transmission/transmission-3.00-r5.ebuild
+++ b/net-p2p/transmission/transmission-3.00-r6.ebuild
@@ -1,9 +1,9 @@
-# Copyright 2006-2022 Gentoo Authors
+# Copyright 2006-2023 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
 EAPI=7
 
-inherit cmake systemd xdg-utils
+inherit cmake flag-o-matic systemd xdg-utils
 
 if [[ ${PV} == 9999 ]]; then
 	inherit git-r3
@@ -21,7 +21,7 @@ HOMEPAGE="https://transmissionbt.com/"
 # MIT is in several libtransmission/ headers
 LICENSE="|| ( GPL-2 GPL-3 Transmission-OpenSSL-exception ) GPL-2 MIT"
 SLOT="0"
-IUSE="appindicator cli gtk lightweight nls mbedtls qt5 systemd test"
+IUSE="appindicator cli debug gtk lightweight nls mbedtls qt5 systemd test"
 RESTRICT="!test? ( test )"
 
 ACCT_DEPEND="
@@ -95,6 +95,9 @@ src_configure() {
 		-DWITH_SYSTEMD=$(usex systemd ON OFF)
 	)
 
+	# Disable assertions by default, bug 893870.
+	use debug || append-cppflags -DNDEBUG
+
 	cmake_src_configure
 }
 
diff --git a/net-p2p/transmission/transmission-4.0.0-r3.ebuild b/net-p2p/transmission/transmission-4.0.0-r4.ebuild
index 0187206cccdf..98ed72317d7d 100644
--- a/net-p2p/transmission/transmission-4.0.0-r3.ebuild
+++ b/net-p2p/transmission/transmission-4.0.0-r4.ebuild
@@ -3,7 +3,7 @@
 
 EAPI=8
 
-inherit cmake tmpfiles systemd xdg-utils
+inherit cmake flag-o-matic tmpfiles systemd xdg-utils
 
 if [[ ${PV} == 9999 ]]; then
 	inherit git-r3
@@ -24,7 +24,7 @@ HOMEPAGE="https://transmissionbt.com/"
 # MIT is in several libtransmission/ headers
 LICENSE="|| ( GPL-2 GPL-3 Transmission-OpenSSL-exception ) GPL-2 MIT"
 SLOT="0"
-IUSE="appindicator cli gtk nls mbedtls qt5 systemd test"
+IUSE="appindicator cli debug gtk nls mbedtls qt5 systemd test"
 RESTRICT="!test? ( test )"
 
 ACCT_DEPEND="
@@ -107,6 +107,9 @@ src_configure() {
 		-DWITH_SYSTEMD=$(usex systemd ON OFF)
 	)
 
+	# Disable assertions by default, bug 893870.
+	use debug || append-cppflags -DNDEBUG
+
 	cmake_src_configure
 }
 
diff --git a/net-p2p/transmission/transmission-9999.ebuild b/net-p2p/transmission/transmission-9999.ebuild
index a4bc807ed3ac..359413eb1aa0 100644
--- a/net-p2p/transmission/transmission-9999.ebuild
+++ b/net-p2p/transmission/transmission-9999.ebuild
@@ -3,7 +3,7 @@
 
 EAPI=8
 
-inherit cmake tmpfiles systemd xdg-utils
+inherit cmake flag-o-matic tmpfiles systemd xdg-utils
 
 if [[ ${PV} == 9999 ]]; then
 	inherit git-r3
@@ -24,7 +24,7 @@ HOMEPAGE="https://transmissionbt.com/"
 # MIT is in several libtransmission/ headers
 LICENSE="|| ( GPL-2 GPL-3 Transmission-OpenSSL-exception ) GPL-2 MIT"
 SLOT="0"
-IUSE="appindicator cli gtk nls mbedtls qt5 systemd test"
+IUSE="appindicator cli debug gtk nls mbedtls qt5 systemd test"
 RESTRICT="!test? ( test )"
 
 ACCT_DEPEND="
@@ -100,6 +100,9 @@ src_configure() {
 		-DWITH_SYSTEMD=$(usex systemd ON OFF)
 	)
 
+	# Disable assertions by default, bug 893870.
+	use debug || append-cppflags -DNDEBUG
+
 	cmake_src_configure
 }