1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
|
From f5a3a224bf00bef5669366d2ae23c2b2b13b8016 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Niels=20M=C3=B6ller?= <nisse@lysator.liu.se>
Date: Wed, 26 Dec 2018 11:04:31 +0100
Subject: [PATCH] Fix accidental use of C99 for loop.
* rsa-sign-tr.c (sec_equal): Fix accidental use of C99 for loop.
Reported by Andreas Gustafsson.
* testsuite/rsa-sec-decrypt-test.c (test_main): Likewise.
---
ChangeLog | 6 ++++++
rsa-sign-tr.c | 3 ++-
testsuite/rsa-sec-decrypt-test.c | 3 ++-
3 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/rsa-sign-tr.c b/rsa-sign-tr.c
index 59c9bd07..f824c4ca 100644
--- a/rsa-sign-tr.c
+++ b/rsa-sign-tr.c
@@ -239,8 +239,9 @@ static int
sec_equal(const mp_limb_t *a, const mp_limb_t *b, size_t limbs)
{
volatile mp_limb_t z = 0;
+ size_t i;
- for (size_t i = 0; i < limbs; i++)
+ for (i = 0; i < limbs; i++)
{
z |= (a[i] ^ b[i]);
}
diff --git a/testsuite/rsa-sec-decrypt-test.c b/testsuite/rsa-sec-decrypt-test.c
index 64f0b13c..fb0ed3a1 100644
--- a/testsuite/rsa-sec-decrypt-test.c
+++ b/testsuite/rsa-sec-decrypt-test.c
@@ -68,6 +68,7 @@ test_main(void)
unsigned n_size = 1024;
mpz_t gibberish;
mpz_t garbage;
+ size_t size;
rsa_private_key_init(&key);
rsa_public_key_init(&pub);
@@ -78,7 +79,7 @@ test_main(void)
memset(verifybad, 'A', PAYLOAD_SIZE);
- for (size_t size = 1; size < 51; size++)
+ for (size = 1; size < 51; size++)
{
ASSERT (rsa_generate_keypair(&pub, &key, &random_ctx,
(nettle_random_func *) knuth_lfib_random,
--
2.18.1
|
GitWeb
