sys-apps/fwupd/files/fwupd-1.3.8-report_uploading.patch


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34

From 5c7e17276c8eb0c2a845cecb7d644a4bccf80519 Mon Sep 17 00:00:00 2001
From: Mario Limonciello <mario.limonciello@dell.com>
Date: Thu, 13 Feb 2020 12:06:41 -0600
Subject: [PATCH] fu-util: fix a logic error in report uploading introduced in
 e076d48afb74d1447936d353f12781755f13b047

Fixes: #1770
---
 src/fu-util.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/fu-util.c b/src/fu-util.c
index 5bcffedeb..e6531c90c 100644
--- a/src/fu-util.c
+++ b/src/fu-util.c
@@ -286,16 +286,12 @@ fu_util_maybe_enable_automatic (FuUtilPrivate *priv, GPtrArray *remotes, GError
 							 NULL, error))
 				return FALSE;
 		}
-		return TRUE;
+		break;
 	default:
 		break;
 	}
 
-	g_set_error_literal (error,
-			     FWUPD_ERROR,
-			     FWUPD_ERROR_NOTHING_TO_DO,
-			     "invalid option selected");
-	return FALSE;
+	return TRUE;
 }
 
 static gboolean