diff options
author | Andreas Sturmlechner <asturm@gentoo.org> | 2017-09-12 15:29:40 +0200 |
---|---|---|
committer | Andreas Sturmlechner <asturm@gentoo.org> | 2017-09-12 22:32:55 +0200 |
commit | d94e4d403a72074c80a12e088cfb2ed055669d76 (patch) | |
tree | ca9547cd2515508030ce07f6ac893e7fdd5c4b5d /kde-frameworks/kdeclarative/files | |
parent | kde-frameworks/kirigami: Drop old (diff) | |
download | gentoo-d94e4d403a72074c80a12e088cfb2ed055669d76.tar.gz gentoo-d94e4d403a72074c80a12e088cfb2ed055669d76.tar.bz2 gentoo-d94e4d403a72074c80a12e088cfb2ed055669d76.zip |
kde-frameworks: Drop KDE Frameworks 5.34.0
Except ECM which is required for hppa.
Package-Manager: Portage-2.3.6, Repoman-2.3.1
Diffstat (limited to 'kde-frameworks/kdeclarative/files')
-rw-r--r-- | kde-frameworks/kdeclarative/files/kdeclarative-5.34.0-memleak.patch | 73 |
1 files changed, 0 insertions, 73 deletions
diff --git a/kde-frameworks/kdeclarative/files/kdeclarative-5.34.0-memleak.patch b/kde-frameworks/kdeclarative/files/kdeclarative-5.34.0-memleak.patch deleted file mode 100644 index 43fdb8a4bf66..000000000000 --- a/kde-frameworks/kdeclarative/files/kdeclarative-5.34.0-memleak.patch +++ /dev/null @@ -1,73 +0,0 @@ -From 695f24fb522a5ae6fe2530cbd72d3966b234b025 Mon Sep 17 00:00:00 2001 -From: David Edmundson <kde@davidedmundson.co.uk> -Date: Wed, 31 May 2017 10:08:25 +0100 -Subject: [PATCH] Don't leak MimeData object - -Summary: -A DeclarativeDropArea creates a new DeclarativeDragDropEvent on every -enter/move/leave event. - -The getter method for the mimeData property creates a new MimeData -QObject wrapper, which then leaks. - -Use of the mimeData object outside of the event shouldn't be expected to -work, and a quick grep couldn't find any usage. - -BUG: 380270 - -Test Plan: Dragged some things - -Reviewers: #plasma, mart, hein - -Reviewed By: #plasma, mart, hein - -Subscribers: hein, plasma-devel, #frameworks - -Tags: #plasma, #frameworks - -Differential Revision: https://phabricator.kde.org/D6017 ---- - src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.cpp | 4 ++-- - src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.h | 5 ++--- - 2 files changed, 4 insertions(+), 5 deletions(-) - -diff --git a/src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.cpp b/src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.cpp -index 5c1b0e3..a75f85f 100644 ---- a/src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.cpp -+++ b/src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.cpp -@@ -65,7 +65,7 @@ DeclarativeMimeData* DeclarativeDragDropEvent::mimeData() - if (!m_data && m_event) { - // TODO This should be using MimeDataWrapper eventually, although this is an API break, - // so will need to be done carefully. -- m_data = new DeclarativeMimeData(m_event->mimeData()); -+ m_data.reset(new DeclarativeMimeData(m_event->mimeData())); - } -- return m_data; -+ return m_data.data(); - } -diff --git a/src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.h b/src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.h -index 3fd846d..b35568a 100644 ---- a/src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.h -+++ b/src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.h -@@ -26,8 +26,7 @@ - - #include <QObject> - #include "DeclarativeDropArea.h" -- --class DeclarativeMimeData; -+#include "DeclarativeMimeData.h" - - class DeclarativeDragDropEvent : public QObject - { -@@ -115,7 +114,7 @@ private: - int m_y; - Qt::MouseButtons m_buttons; - Qt::KeyboardModifiers m_modifiers; -- DeclarativeMimeData* m_data; -+ QScopedPointer<DeclarativeMimeData> m_data; - QDropEvent* m_event; - }; - --- -2.13.0 - |